amogh-jahagirdar commented on code in PR #17320:
URL: https://github.com/apache/iceberg/pull/17320#discussion_r3925897523
##########
data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java:
##########
@@ -182,4 +184,154 @@ public void testTwoLevelList() throws IOException {
assertThat(Lists.newArrayList(reader)).hasSize(1);
}
}
+
+ @Test
Review Comment:
I did keep a more "representative" test but dropped the other one; the
rationale for keeping the more realistic test for generic reader was that even
though all of the other tests share the same Parquet reader logic, there's
still some logic in the different implementations which adapt to the engine
record type (e.g. FlinkParquetReaders/ SparkParquetReaders) which compute
things like `readersById` and invoke the newly added `structFieldReader`.
The Generic case is another implementation of that and we'd want to catch
any bugs in that middle layer that may only apply for generic reader but don't
impact the Spark/Flink ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
