gaborkaszab commented on code in PR #17928:
URL: https://github.com/apache/iceberg/pull/17928#discussion_r3924002464
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -346,6 +334,39 @@ void dvDeleteFileAdapterRejectsNullDeletionVector() {
.hasMessage("Cannot create DV delete file: no deletion vector");
}
+ @Test
+ void dataFileExposesColocatedDeletionVector() {
Review Comment:
Can this be merged into `dataFileAdapterDelegation`? It exercises setting
all the valid fields for a data file through an adapter, DV is not different
than them.
##########
api/src/main/java/org/apache/iceberg/DataFile.java:
##########
@@ -164,4 +164,14 @@ default FileContent content() {
default List<Integer> equalityFieldIds() {
return null;
}
+
+ /**
+ * Returns the deletion vector co-located or tracked with this data file, or
null if there isn't
+ * one.
+ *
+ * <p>A delete manifest can contain a deletion vector even if this
co-located DV is null.
Review Comment:
I see this sentence is a result of a previous comment, but isn't mentioning
delete manifests here is a different level of abstraction? At the data file
level we shouldn't be concerned about delete manifest level things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
