rdblue commented on code in PR #17928:
URL: https://github.com/apache/iceberg/pull/17928#discussion_r3918980323


##########
api/src/main/java/org/apache/iceberg/DataFile.java:
##########
@@ -164,4 +164,9 @@ default FileContent content() {
   default List<Integer> equalityFieldIds() {
     return null;
   }
+
+  /** Returns the deletion vector co-located with this data file, or null if 
there is none. */
+  default DeleteFile deletionVector() {

Review Comment:
   I think that this should return `DeletionVector` rather than `DeleteFile`. 
DV is more specific and correct, since we don't intend to pass a v3 DV or any 
v2 delete files here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to