zeroshade commented on PR #1974: URL: https://github.com/apache/iceberg-go/pull/1974#issuecomment-5488005008
My approval above stands, but this went conflicted before I could merge it. Same cause as #1965: the duplicated `schema.go` `MarshalJSON` lazy-cache hunk shared across this stack has now landed on `main`, so the identical hunk here conflicts. A rebase onto current `main` should drop it and leave just the streaming-planner change. Once rebased and green I'll merge — no need to re-request review. The two minor follow-ups from my review (context check between entries, planner-level edge-case tests) are fine to pick up here or separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
