fallintoplace opened a new pull request, #1974: URL: https://github.com/apache/iceberg-go/pull/1974
## Summary - **Streams data manifest entries directly into scan tasks** instead of keeping a global data-entry slice. - Reads delete manifests first and builds positional, equality, and deletion-vector indexes. - Reads data manifests concurrently while keeping task order by manifest order. - Uses one shared task buffer when manifest counts are known. Unknown counts use a safe fallback. - Keeps the existing collector for incremental append scans. ## Tests - `go test ./...` - `go test -race ./table` - `go vet ./table` ## Benchmark Command: `go test ./table -run '^$' -bench '^BenchmarkPlanDataManifestTasks/manifests=8/entries=10000/(buffered|streamed)$' -benchmem -benchtime=1s` Apple M1 Pro, 8 manifests x 10,000 entries: | Path | ns/op | B/op | allocs/op | | --- | ---: | ---: | ---: | | buffered | 28,409,791 | 86,939,909 | 905,562 | | streamed | 23,727,901 | 80,683,642 | 905,561 | The streamed path is about **16% faster** and uses about **7% fewer allocated bytes** on this workload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
