blackmwk commented on code in PR #3101:
URL: https://github.com/apache/iceberg-rust/pull/3101#discussion_r3891319740
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -156,9 +150,10 @@ impl MemoryCatalog {
let factory = storage_factory.unwrap_or_else(||
Arc::new(MemoryStorageFactory));
Ok(Self {
+ name,
+ properties,
+ file_io: FileIOBuilder::new(factory).with_props(props).build(),
Review Comment:
After maintainer follow-up, we are intentionally forwarding the complete raw
property map, including `warehouse`, to FileIO and KMS in 75b0134c. This
matches Java behavior and avoids maintaining a catalog-specific denylist as
properties evolve. The focused test now locks in forwarding of both
`custom.property` and `warehouse`. Reopening this thread because we chose not
to apply the requested filtering.
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -458,6 +463,35 @@ pub(crate) mod tests {
temp_dir.path().to_str().unwrap().to_string()
}
+ #[test]
+ fn test_catalog_properties() {
+ let properties =
MemoryCatalogProperties::from_properties(&HashMap::from([
+ (
+ MEMORY_CATALOG_WAREHOUSE.to_string(),
+ "memory:///warehouse".to_string(),
+ ),
+ ("custom.property".to_string(), "value".to_string()),
Review Comment:
Follow-up in 75b0134c: the custom-property forwarding assertion remains, and
the test now also verifies that `warehouse` reaches FileIO to reflect the final
Java-compatible raw-forwarding decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
