blackmwk commented on code in PR #3101:
URL: https://github.com/apache/iceberg-rust/pull/3101#discussion_r3880503796
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
+ #[property(key = MEMORY_CATALOG_WAREHOUSE, default = "")]
+ warehouse: String,
+ #[property(prefix = "")]
+ props: HashMap<String, String>,
Review Comment:
Removed the catch-all `props` field. The original map is now kept separately
only long enough to forward unmodeled properties to FileIO and KMS.
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
Review Comment:
Updated `MemoryCatalogProperties` to be public and refreshed the checked-in
public API snapshot.
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -127,6 +120,14 @@ impl CatalogBuilder for MemoryCatalogBuilder {
}
}
+#[derive(Properties)]
+struct MemoryCatalogProperties {
+ #[property(key = MEMORY_CATALOG_WAREHOUSE, default = "")]
+ warehouse: String,
+ #[property(prefix = "")]
+ props: HashMap<String, String>,
+}
+
#[derive(Clone, Debug)]
pub(crate) struct MemoryCatalogConfig {
Review Comment:
Removed `MemoryCatalogConfig`. `MemoryCatalog` now retains the catalog name
and `MemoryCatalogProperties` directly, and warehouse-based location generation
reads from the typed properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
