blackmwk commented on code in PR #3090:
URL: https://github.com/apache/iceberg-rust/pull/3090#discussion_r3885182994
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -59,13 +60,14 @@ use crate::Result;
/// .with_prop("key", "value")
/// .build();
/// ```
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct FileIO {
/// Storage configuration containing properties
config: StorageConfig,
Review Comment:
Addressed in
[1bd015b4](https://github.com/apache/iceberg-rust/pull/3090/commits/1bd015b4cdde2cf2e1e1652eb5413ee325af44c0).
now documents that all properties, including credentials, are serialized and
that applications must protect the payload in transit and at rest. The core
snapshot also pins preservation of an property.
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -59,13 +60,14 @@ use crate::Result;
/// .with_prop("key", "value")
/// .build();
/// ```
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct FileIO {
/// Storage configuration containing properties
config: StorageConfig,
/// Factory for creating storage instances
factory: Arc<dyn StorageFactory>,
Review Comment:
Addressed in
[1bd015b4](https://github.com/apache/iceberg-rust/pull/3090/commits/1bd015b4cdde2cf2e1e1652eb5413ee325af44c0).
The loader-specific behavior is documented on both concrete OpenDAL factories,
and regression tests confirm that the direct S3 and resolving factories omit
custom credential loaders from serialized output.
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -59,13 +60,14 @@ use crate::Result;
/// .with_prop("key", "value")
/// .build();
/// ```
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
Review Comment:
Addressed in
[1bd015b4](https://github.com/apache/iceberg-rust/pull/3090/commits/1bd015b4cdde2cf2e1e1652eb5413ee325af44c0).
Added a section covering the skipped/rebuilt cache, full configuration
payload, typetag registration in the receiving binary, and the requirement for
third-party factories to use .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
