kinolaev commented on PR #15714: URL: https://github.com/apache/iceberg/pull/15714#issuecomment-5455864414
Thanks @anuragmantri , I'll create a separate PR for rehashing issue without `common-lang3` dependency soon. Once again regarding the revert: **disabling the cache broke equality deletes compaction**. While caching might not always be useful for position deletes, it is required for equality deletes. Without it, an equality delete file referenced by 10 data files will be loaded 10 times. This seems like a clear justification for reverting the change, doesn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
