anuragmantri commented on PR #15714: URL: https://github.com/apache/iceberg/pull/15714#issuecomment-5455711345
Hi @kinolaev, thanks for the PR. I suggest: - Separate out the rehashing into a separate fa492a6ead4eeb06d0275511b32822c6cb8749f5. I'm not yet convinced we need the revert yet, let me think about it a bit more. - We avoid using dependencies like `common-lang3` in the core module. (See https://github.com/apache/iceberg/pull/2102). Can you use an alternative like `Comparators.filePath().compare(...) == 0` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
