blackmwk commented on PR #3044: URL: https://github.com/apache/iceberg-rust/pull/3044#issuecomment-5437201385
Hi, @CTTY @laskoviymishka I agree that the original loosy parsing design is over simplifed and error prone. To deal with table property parsing, I switch the design to generate a property view, which parses each field on the fly when using the getter instead of parsing all properties. This behavior now matches exactly java's behavior. The only downside is that same field will be parsed more than once, which may lead to a little performance regression. But compared with other solution with Lazy/OnceLock for each field, this solution save memroy usage, and is more light weight. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
