blackmwk commented on PR #3044: URL: https://github.com/apache/iceberg-rust/pull/3044#issuecomment-5418916508
> The change looks good to me, but I don't quite understand the intention here: why do we want an infallible properties parser? It's used to address this comment: https://github.com/apache/iceberg-rust/pull/3030#discussion_r3833951934 > I think the value should only fall back to default when it's unset. Invalid properties should be rejected The motivation is that we should be less strict when reading, but more strict when writing, according to some discussion earlier in dev list. Also this is to be align with java/python libraries behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
