ryanworl commented on PR #1834: URL: https://github.com/apache/iceberg-go/pull/1834#issuecomment-5431465237
Rebased on latest main and addressed both of @laskoviymishka's points: - New `TestUpdateSpecRemoveOnlyRaceIsFenced` exercises the race directly: writer A's requirements from a remove-only evolution are validated against metadata where the same evolution already committed. `assert-last-assigned-partition-id` passes (no new field ids were assigned), and exactly `assert-default-spec-id` fails. - Fixed the inverted comment — it now says the two racing evolutions *can* both pass the last-assigned check. `go test ./table/...` and golangci-lint (v2.12.2) are clean on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
