JosephLenton commented on code in PR #2937:
URL: https://github.com/apache/iceberg-rust/pull/2937#discussion_r3861040368
##########
crates/iceberg/src/lib.rs:
##########
@@ -94,7 +94,7 @@ pub mod transaction;
pub mod transform;
mod runtime;
-pub use runtime::{Runtime, RuntimeHandle};
+pub use runtime::{JoinHandle, Runtime, RuntimeHandle};
Review Comment:
Like in the other comment, this is exported on the main docs but it's type
information is missing. For example it's the return type here:
https://docs.rs/iceberg/latest/iceberg/struct.RuntimeHandle.html#method.spawn .
Making it public makes it show up in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
