JosephLenton commented on code in PR #2937: URL: https://github.com/apache/iceberg-rust/pull/2937#discussion_r3861031315
########## crates/iceberg/src/transaction/mod.rs: ########## @@ -73,14 +73,14 @@ use crate::error::Result; use crate::spec::TableProperties; use crate::table::Table; use crate::transaction::action::BoxedTransactionAction; -use crate::transaction::append::FastAppendAction; -use crate::transaction::expire_snapshots::ExpireSnapshotsAction; -use crate::transaction::sort_order::ReplaceSortOrderAction; -use crate::transaction::update_location::UpdateLocationAction; -use crate::transaction::update_properties::UpdatePropertiesAction; -use crate::transaction::update_schema::UpdateSchemaAction; -use crate::transaction::update_statistics::UpdateStatisticsAction; -use crate::transaction::upgrade_format_version::UpgradeFormatVersionAction; +pub use crate::transaction::append::FastAppendAction; Review Comment: This is one of the issues with the docs. The type is public in the docs. For example here it is on main: https://docs.rs/iceberg/latest/iceberg/transaction/struct.Transaction.html#method.fast_append . However none of the type information is available because the type isn't exported from the crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
