RussellSpitzer commented on code in PR #17808:
URL: https://github.com/apache/iceberg/pull/17808#discussion_r3854447881
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -61,13 +61,14 @@ public class Schema implements Serializable {
@VisibleForTesting static final int DEFAULT_VALUES_MIN_FORMAT_VERSION = 3;
@VisibleForTesting
- static final Map<Type.TypeID, Integer> MIN_FORMAT_VERSIONS =
+ static final Map<Class<? extends Type>, Integer> MIN_FORMAT_VERSIONS =
Review Comment:
I really didn't want to have to do this, but since File type shares an ID
with Struct Type we can't match on that. Matching on class is a little less
clean but the other option is to add a new type for file ID and then change our
code everywhere that checks whether something is a Struct by typeId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
