RussellSpitzer commented on code in PR #17808:
URL: https://github.com/apache/iceberg/pull/17808#discussion_r3854301060
##########
api/src/main/java/org/apache/iceberg/types/AssignFreshIds.java:
##########
@@ -48,15 +48,24 @@ class AssignFreshIds extends
TypeUtil.CustomOrderSchemaVisitor<Type> {
this.nextId = nextId;
}
- private int idFor(String fullName) {
+ private int idFor(String fullName, Type type) {
+ Integer existingId = baseId(fullName);
+ if (existingId != null) {
+ return existingId;
+ }
+
+ return type.isFileType() ? nextId.get(Types.FileType.NUM_NESTED_FIELDS) :
nextId.get();
Review Comment:
When we assign ID's we have to burn ID's equal to the number of fields
within the File type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
