dannycjones commented on code in PR #3032:
URL: https://github.com/apache/iceberg-rust/pull/3032#discussion_r3829074197
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -199,14 +206,33 @@ impl CatalogBuilder for SqlCatalogBuilder {
let name = name.into();
let mut valid_sql_bind_style = true;
- if let Some(sql_bind_style) =
self.config.props.remove(SQL_CATALOG_PROP_BIND_STYLE) {
+
+ // Accept the preferred `sql.bind-style` key, falling back to the
legacy `sql_bind_style`.
+ let sql_bind_style = self
+ .config
+ .props
+ .remove(SQL_CATALOG_PROP_BIND_STYLE)
Review Comment:
I noticed this too but didn't have a preference. It is already established
convention in the file. The URI and warehouse location would need to clone if
we only borrowed from the config map.
I'm happy with it as is, but I can also move the rest of the `load` method
to borrow (and clone if needed) instead of consume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
