dannycjones commented on code in PR #3032:
URL: https://github.com/apache/iceberg-rust/pull/3032#discussion_r3829076048
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -199,14 +206,33 @@ impl CatalogBuilder for SqlCatalogBuilder {
let name = name.into();
let mut valid_sql_bind_style = true;
- if let Some(sql_bind_style) =
self.config.props.remove(SQL_CATALOG_PROP_BIND_STYLE) {
+
+ // Accept the preferred `sql.bind-style` key, falling back to the
legacy `sql_bind_style`.
+ let sql_bind_style = self
+ .config
+ .props
+ .remove(SQL_CATALOG_PROP_BIND_STYLE)
+ .or_else(||
self.config.props.remove(SQL_CATALOG_PROP_BIND_STYLE_LEGACY));
+
+ // Validate the SQL bind style
+ if let Some(sql_bind_style) = sql_bind_style {
if let Ok(sql_bind_style) =
SqlBindStyle::from_str(&sql_bind_style) {
self.config.sql_bind_style = sql_bind_style;
} else {
valid_sql_bind_style = false;
}
}
+ // Parse the requested schema version up front so invalid values fail
fast rather than
+ // silently falling back to V0.
+ let mut valid_schema_version = true;
+ if let Some(schema_version) =
self.config.props.remove(SQL_CATALOG_PROP_SCHEMA_VERSION) {
Review Comment:
Will address comment in this thread:
https://github.com/apache/iceberg-rust/pull/3032#discussion_r3829074197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
