findepi commented on code in PR #17708:
URL: https://github.com/apache/iceberg/pull/17708#discussion_r3821451907
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -400,7 +400,10 @@ private void commitSimpleTransaction() {
}
}
- Set<String> committedFiles = committedFiles(ops, newSnapshots);
+ // resolve the new snapshots against the metadata this transaction
committed. re-reading
+ // through ops.current() can return stale metadata when the catalog
caches table pointers,
+ // which would make the new snapshots appear missing and skip clean-up
entirely.
Review Comment:
I don't think it's necessary and it's definitely more verbose than needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
