anoopj commented on code in PR #17708:
URL: https://github.com/apache/iceberg/pull/17708#discussion_r3814546650
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -460,18 +463,19 @@ private void applyUpdates(TableOperations underlyingOps) {
// committedFiles returns null whenever the set of committed files
// cannot be determined from the provided snapshots
- private static Set<String> committedFiles(TableOperations ops, Set<Long>
snapshotIds) {
+ private static Set<String> committedFiles(
Review Comment:
Looks like the `else` block and the `return null` on line 476 will become
unreachable? It's fine if we just want to keep the defensive check there
regardless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
