szehon-ho commented on PR #17484: URL: https://github.com/apache/iceberg/pull/17484#issuecomment-5350095851
Hm, replace is better for perf than replaceAll. It's not called enough to make huge difference, but I dont see why it's a bad improvement. Moreover, I think replaceAll doesnt make sense here, as replaceAll interprets regex's (which is not what is meant in these call sites.) Maybe we can change the core files? I dont think those particular files are touched that much? The test changes probably wont matter that much to warrant church, and we can do it separately if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
