szehon-ho commented on PR #17484: URL: https://github.com/apache/iceberg/pull/17484#issuecomment-5361723283
So iiuc, the concern from switch discussion is touching too many files to force pr rebase. It seems nice to change replaceAll and lock it via the rule as you suggest. I had actually thought about it yesterday, if we want to only allow replaceAll for regex literals, the rule like this is too strong. It could also work if we ban replaceAll for all literal and just force explicit Pattern.compile(...).replaceAll. Yea agree its not the most important thing in the world, but the surface area does not seem as big here as the switch pr (84 files there..), but I may have missed additional context from missing that conversation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
