uros-b commented on code in PR #17713:
URL: https://github.com/apache/iceberg/pull/17713#discussion_r3809170402
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java:
##########
@@ -119,21 +120,32 @@ protected void send(List<Event> events,
Map<TopicPartition, Offset> sourceOffset
protected void consumeAvailable(Duration pollDuration) {
Review Comment:
Please note that there might be some unresolved cross-PR consolidation here.
This exact replay-dedup guard is duplicated, byte-equivalent, in the earlier
open #17376 and #17450 (same file, same method). Should we pick one vehicle for
the fix and reconcile the others to avoid merge conflicts? The focused
TestControlTopicReplay regression coverage added here is worth preserving,
whichever PR lands. This is just a consolidation decision, not a code defect.
Otherwise, looks good - thank you @ajreid21!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
