ajreid21 commented on code in PR #17713:
URL: https://github.com/apache/iceberg/pull/17713#discussion_r3823282650
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java:
##########
@@ -119,21 +120,32 @@ protected void send(List<Event> events,
Map<TopicPartition, Offset> sourceOffset
protected void consumeAvailable(Duration pollDuration) {
Review Comment:
I created this PR to target this specific case as it is a much simpler case
(and fix) to reason about. This PR is not intended to try and fix all the
potential coordinator replay and zombie issues -- these larger issues require
much more discussion and larger PRs (like the 2 referenced) that may take many
review cycles to get in.
I think it still makes sense to get this (ultimately, ~5 line code addition)
in in the meantime to help prevent this particular issue from happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
