gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3752995029
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -175,10 +204,22 @@ void doNotInheritSequenceNumberForModifiedEntries() {
assertThat(tracking.fileSequenceNumber()).isEqualTo(6L);
}
+ @Test
+ void inheritDataSequenceNumberAfterColumnFilesChange() {
+ // Adding column files should set data sequence number to null
Review Comment:
You're right, mentioning column files in the comment can be misleading, I
wanted to emulate how Tracking would look like if column files were set.
Thanks for the naming suggestion, I applied it! And removed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
