brgr-s commented on code in PR #2936:
URL: https://github.com/apache/iceberg-rust/pull/2936#discussion_r3727710523
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -144,23 +188,50 @@ impl PopulatedDeleteFileIndex {
}
let destination_map = match arc_ctx.manifest_entry.content_type() {
- DataContentType::PositionDeletes => &mut
pos_deletes_by_partition,
+ DataContentType::PositionDeletes => {
+ if let Some(path) =
position_delete_target(arc_ctx.manifest_entry.data_file()) {
+ pos_deletes_by_path
+ .entry(path)
+ .or_default()
+ .push(arc_ctx.clone());
+ return;
+ }
+ &mut pos_deletes_by_partition
+ }
DataContentType::EqualityDeletes => &mut
eq_deletes_by_partition,
_ => unreachable!(),
};
destination_map
- .entry(partition.clone())
+ .entry((arc_ctx.partition_spec_id, partition.clone()))
.and_modify(|entry| {
entry.push(arc_ctx.clone());
})
.or_insert(vec![arc_ctx.clone()]);
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
