brgr-s commented on code in PR #2936:
URL: https://github.com/apache/iceberg-rust/pull/2936#discussion_r3727674650
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -182,32 +253,34 @@ impl PopulatedDeleteFileIndex {
})
.for_each(|delete| results.push(delete.as_ref().into()));
- if let Some(deletes) =
self.eq_deletes_by_partition.get(data_file.partition()) {
+ let partition_key = (data_file.partition_spec_id,
data_file.partition().clone());
Review Comment:
yeah, I was worried that would come up. I just didn't like the shape of a
nested `HashMap`. I concede that this is not a very good reason ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
