zakariya-s commented on code in PR #2932:
URL: https://github.com/apache/iceberg-rust/pull/2932#discussion_r3689827205
##########
crates/storage/opendal/src/utils.rs:
##########
@@ -27,3 +27,25 @@ pub(crate) fn from_opendal_error(e: opendal::Error) ->
iceberg::Error {
)
.with_source(e)
}
+
+/// Convert a [`SystemTime`](std::time::SystemTime) credential expiry into the
+/// `reqsign` [`Timestamp`](reqsign_core::time::Timestamp) used on backend
+/// credential types (e.g. `AwsCredential::expires_in`,
`google::Token::expires_at`).
+#[cfg(any(feature = "opendal-s3", feature = "opendal-gcs"))]
+pub(crate) fn system_time_to_timestamp(
Review Comment:
Didn't want to rely on directly on reqsign's `Timestamp`, but I'm happy to
hear different opinions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
