zakariya-s commented on code in PR #2932:
URL: https://github.com/apache/iceberg-rust/pull/2932#discussion_r3689802681
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -553,6 +611,12 @@ impl Storage for OpenDalStorage {
let mut deleters: HashMap<String, opendal::Deleter> = HashMap::new();
while let Some(path) = paths.next().await {
+ if self.uses_dynamic_credentials(&path) {
+ let (op, relative_path) = self.create_operator(&path)?;
+ op.delete(relative_path).await.map_err(from_opendal_error)?;
+ continue;
+ }
Review Comment:
This will probably need to be looked at again later since we forgo batching
for paths with a vended credential provider. We would probably have to batch by
path-prefix to make this work later. Happy to do this later in this PR or in a
new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
