rraulinio commented on code in PR #1432:
URL: https://github.com/apache/iceberg-go/pull/1432#discussion_r3569508132
##########
catalog/rest/rest.go:
##########
@@ -1038,6 +1039,14 @@ func (r *Catalog) splitViewIdentForPath(ident
table.Identifier) (string, string,
return r.encodeNamespace(catalog.NamespaceFromIdent(ident)),
catalog.TableNameFromIdent(ident), nil
}
+func (r *Catalog) splitFunctionIdentForPath(ident table.Identifier) (string,
string, error) {
+ if err := catalog.ValidateFunctionIdentifier(ident); err != nil {
+ return "", "", err
+ }
+
+ return r.encodeNamespace(catalog.NamespaceFromIdent(ident)),
catalog.TableNameFromIdent(ident), nil
Review Comment:
Addressed, I added `catalog.ObjectNameFromIdent`, retained
`TableNameFromIdent` as a compatibility alias and updated the table, view and
function REST path splitters to use the type-neutral helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
