rraulinio commented on code in PR #1432: URL: https://github.com/apache/iceberg-go/pull/1432#discussion_r3569420533
########## udf/udf.go: ########## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package udf + +import ( + "slices" + + "github.com/apache/iceberg-go" + "github.com/apache/iceberg-go/table" +) + +// UDF is a function (SQL UDF) loaded from a catalog: its catalog identifier, +// its metadata, and the location the metadata was loaded from. +type UDF struct { + identifier table.Identifier + metadata Metadata + metadataLocation string +} + +// New creates a UDF from its catalog identifier, metadata and metadata +// location. +func New(ident table.Identifier, meta Metadata, metadataLocation string) *UDF { + return &UDF{ + identifier: ident, + metadata: meta, + metadataLocation: metadataLocation, + } +} + +// Equals reports whether two UDFs have the same identifier, metadata +// location and metadata. +func (u UDF) Equals(other UDF) bool { Review Comment: Kept the value receiver and argument to match `view.View` and added documentation making the intentional value-copy semantics and pointer-call usage explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
