varun-lakhyani commented on issue #16033: URL: https://github.com/apache/iceberg/issues/16033#issuecomment-4948496199
> The referenced aircompressor PR ([airlift/aircompressor#142](https://github.com/airlift/aircompressor/pull/142)) has been merged, so the dependency is available. > > ### Expected behavior > Either: > > * Implement LZ4 frame compression/decompression using the now-available aircompressor library, or > * Throw a clear error in `Puffin.WriteBuilder.compressFooter()` indicating LZ4 is not yet supported, rather than failing deep in the write path Nit. Not sure if we have this LZ4 compression and decompression as what we want in aircompressor's version v2 (what we are using). https://github.com/airlift/aircompressor/pull/357 is approved and might be merged soon but it will need bumping v2 to v3 for aircompressor which might need lots of changes. So , It would be better if we can update the expected behavior to use LZ4FrameOutputStream and LZ4FrameInputStream as have been done in PR so for. Or better, to get some feedback if anyone thinks aircompressor path is much better suited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
