amirmor1 opened a new pull request, #17164:
URL: https://github.com/apache/iceberg/pull/17164

   ## Summary
   - Add an optional `metadata-file-size-bytes` metric to `CommitMetricsResult` 
and JSON serde.
   - Capture metadata file size at write time via new additive APIs in 
`TableMetadataParser` and expose it through 
`TableOperations#metadataFileSizeInBytes()`.
   - Populate `CommitReport` with this metric in `SnapshotProducer` when the 
table operations implementation provides the value.
   - Add coverage in core metrics parser/report parser tests and Hadoop commit 
reporting tests.
   - Update metrics reporting docs for the new commit metric.
   
   ## Why
   - Exposes useful commit metadata size telemetry to `MetricsReporter` 
consumers.
   - Captures size during write to avoid an extra metadata-file read after 
commit.
   
   ## Compatibility
   - Existing `TableMetadataParser.write/overwrite/internalWrite` behavior 
remains intact.
   - New APIs are additive (`writeAndReturnLength`, `overwriteAndReturnLength`).
   - Metric is optional and may be `null` for table operations that cannot 
provide write-time size.
   
   ## Test plan
   - [x] `./gradlew :iceberg-core:test --tests 
org.apache.iceberg.metrics.TestCommitMetricsResultParser`
   - [x] `./gradlew :iceberg-core:test --tests 
org.apache.iceberg.metrics.TestCommitReportParser`
   - [x] `./gradlew :iceberg-core:test --tests 
org.apache.iceberg.hadoop.TestHadoopCommits`
   - [x] `./gradlew :iceberg-core:spotlessCheck`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to