nssalian commented on code in PR #16568:
URL: https://github.com/apache/iceberg/pull/16568#discussion_r3555507375
##########
api/src/main/java/org/apache/iceberg/variants/SerializedObject.java:
##########
@@ -163,9 +198,16 @@ public String next() {
private int id(int index) {
if (null == fieldIds[index]) {
- fieldIds[index] =
+ int dictSize = metadata.dictionarySize();
Review Comment:
Added a comment noting construction doesn't validate field ids (they're
checked lazily on first access). Agree the on-demand approach rust takes reads
best, but that's a larger redesign.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
