steveloughran commented on PR #16568: URL: https://github.com/apache/iceberg/pull/16568#issuecomment-4906752155
@laskoviymishka great comments here, would love the reviews on the parquet one as you know details that we may have missed. I don't want these parsing tests to be stricter than the spec and so reject valid files created by other tools. @nssalian just added fixed depth to 1000 + two new tests - you should skip an unknown primitive type. (not a MUST, just a SHOULD). - it's ok for two dictionary keys to point to same offset (from the comments here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
