cbb330 commented on code in PR #16692:
URL: https://github.com/apache/iceberg/pull/16692#discussion_r3554999833
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -471,6 +472,86 @@ public void testColumnNotInFile() {
}
}
+ @TestTemplate
+ public void testColumnNotInFileWithInitialDefault() {
Review Comment:
thanks for the suggestion Steven. Added all three:
* startsWith/notStartsWith on country (matching "U" and skipping "X", plus
symmetric notStartsWith cases)
* a DateType field test using the raw Integer internal representation for
lt/gt/eq to guard the cast
* a DoubleType field with a non-NaN default covering both isNaN (skip) and
notNaN (match)
All follow the existing "field id not in file" pattern with fresh ids, no
new fixtures. Let me know if you'd like different coverage for the non-string
default case (I used Integer/date. also happy to add decimal/binary too if
useful).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
