amogh-jahagirdar commented on code in PR #16692:
URL: https://github.com/apache/iceberg/pull/16692#discussion_r3554576227
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -60,6 +63,12 @@ public ParquetMetricsRowGroupFilter(Schema schema,
Expression unbound, boolean c
this.schema = schema;
StructType struct = schema.asStruct();
this.expr = Binder.bind(struct, Expressions.rewriteNot(unbound),
caseSensitive);
+ this.initialDefaults = Maps.newHashMap();
+ for (Types.NestedField field : schema.columns()) {
Review Comment:
Yeah we should just use the existing map to lookup by ID, no need for the
extra mapping as it doesn't even save anything when we already need to keep all
the field IDs in memory anyway. That addresses the nested field issue as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
