zeroshade commented on code in PR #1378:
URL: https://github.com/apache/iceberg-go/pull/1378#discussion_r3553758393
##########
table/internal/parquet_files.go:
##########
@@ -74,12 +74,20 @@ const (
type parquetFormat struct{}
-func (parquetFormat) Open(ctx context.Context, fs iceio.IO, path string)
(FileReader, error) {
+func (parquetFormat) Open(ctx context.Context, fs iceio.IO, path string)
(result FileReader, err error) {
Review Comment:
nit: the named return `result` isn't needed here — the defer only inspects
`err`. `(_ FileReader, err error)` plus `return wrapPqArrowReader{...}, nil`
would be a touch cleaner. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
