tanmayrauth commented on code in PR #1378:
URL: https://github.com/apache/iceberg-go/pull/1378#discussion_r3523577928
##########
table/internal/parquet_files.go:
##########
@@ -74,12 +74,18 @@ const (
type parquetFormat struct{}
-func (parquetFormat) Open(ctx context.Context, fs iceio.IO, path string)
(FileReader, error) {
+func (parquetFormat) Open(ctx context.Context, fs iceio.IO, path string)
(result FileReader, err error) {
Review Comment:
The defer only reads `err`, never `result`, so the named `result` isn't
buying anything — you could drop it to `(_ FileReader, err error)` and keep
`return wrapPqArrowReader{arrRdr}, nil` at the bottom, which still satisfies
nlreturn without the `result = ...; return result, nil` two-step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
