zeroshade commented on code in PR #1400:
URL: https://github.com/apache/iceberg-go/pull/1400#discussion_r3553539755
##########
table/internal/parquet_files.go:
##########
@@ -387,6 +392,19 @@ func (p parquetFormat) NewFileWriter(ctx context.Context,
fs iceio.WriteFileIO,
}, nil
}
+func getWriteProperties(writeProps any) (*parquet.WriterProperties, error) {
+ if writeProps == nil {
+ return nil, fmt.Errorf("%w: write properties are required",
iceberg.ErrInvalidArgument)
Review Comment:
nit: since `WriteProps` is typed `any`, a reader might reasonably expect
`nil` to mean "use defaults". A brief comment documenting that nil is
intentionally treated as an error (fail-fast) rather than defaulting to
`parquet.NewWriterProperties()` would avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
