rdblue commented on code in PR #17041:
URL: https://github.com/apache/iceberg/pull/17041#discussion_r3546233480
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -104,6 +105,31 @@ private TrackingStruct(TrackingStruct toCopy) {
this.replacedPositions = replacedPositions;
}
+ @VisibleForTesting
+ TrackingStruct(
Review Comment:
> I wasn't sure about the set+position approach, hence I introduced the
constructor for tests.
We don't want `set` to be the only way to fill these objects with data.
That's just brittle when we can use an all-args constructor that is needed to
create these anyway. But I think the stronger concern here is that we don't
want anyone to think _pos or manifest_location can be user-supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
