anoopj commented on code in PR #17041:
URL: https://github.com/apache/iceberg/pull/17041#discussion_r3540423429
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -23,14 +23,15 @@
import java.util.Arrays;
import java.util.Objects;
import org.apache.iceberg.avro.SupportsIndexProjection;
+import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.types.Types;
import org.apache.iceberg.util.ByteBuffers;
/** Mutable {@link StructLike} implementation of {@link Tracking}. */
class TrackingStruct extends SupportsIndexProjection implements Tracking,
Serializable {
- private static final Types.StructType BASE_TYPE =
+ static final Types.StructType BASE_TYPE =
Review Comment:
+1. We already use `Tracking.schema()` this in
[TestTrackedFileAdapters](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
