wgtmac commented on PR #725: URL: https://github.com/apache/iceberg-cpp/pull/725#issuecomment-4913399705
I put together a small draft PR with the macro shape I had in mind: #824. My concern here is mostly about the structure, not individual lines. Right now `logger.h` exposes macros to every consumer, short `LOG_*` names are on the default path, and the fixed-level/runtime/explicit/fatal paths duplicate formatting, filtering, and fatal handling logic. The prototype keeps `logger.h` as the C++ API only, moves `ICEBERG_*` macros to `log_macros.h`, puts `LOG_*` aliases behind an opt-in header, and uses preprocessor active-level gating. Not suggesting it should replace this PR; it is just a concrete reference for the direction I think would be easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
