huan233usc commented on code in PR #17119:
URL: https://github.com/apache/iceberg/pull/17119#discussion_r3538419998
##########
core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java:
##########
@@ -44,6 +44,11 @@ protected boolean supportsVariant() {
return true;
}
+ @Override
+ protected boolean supportsGeospatial() {
Review Comment:
Done — enabled supportsGeospatial() on TestAvroEncoderUtil in 67619a712, so
geo now round-trips through the AvroEncoderUtil.encode/decode entry point too,
keeping the two generic-model Avro tests in parity (good call on the #16982
coverage-parity precedent).
I also added explicit WKB round-trip tests while here:
- TestAvroDataWriter.testGeospatialWkbRoundTrip — geometry/geography through
the Avro DataWriter → PlannedDataReader path, including nulls.
- TestParquet.testGeospatialWkbRoundTrip — through ParquetAvroWriter →
ParquetAvroValueReaders,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
