wombatu-kun commented on code in PR #17119:
URL: https://github.com/apache/iceberg/pull/17119#discussion_r3533118941
##########
core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java:
##########
@@ -44,6 +44,11 @@ protected boolean supportsVariant() {
return true;
}
+ @Override
+ protected boolean supportsGeospatial() {
Review Comment:
`TestAvroEncoderUtil` extends `DataTestBase` and round-trips generic records
through this same `TypeToSchema` + `RandomAvroData` path via
`AvroEncoderUtil.encode/decode`, and on `main` it mirrors this test's type
flags exactly (`supportsUnknown`, `supportsTimestampNanos`, `supportsVariant`).
Enabling `supportsGeospatial()` there as well covers geo through the encoder
entry point for free and keeps the two generic-model Avro tests in parity.
szehon-ho raised the same coverage-parity point on the sibling Parquet PR
#16982.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
