yadavay-amzn commented on PR #819: URL: https://github.com/apache/iceberg-cpp/pull/819#issuecomment-4896571203
Thanks @evindj - it's a real occurrence, not hypothetical. Arrow injects its own -Werror during its build, and as noted on the issue by @wgtmac/@zhjwpku the global CMAKE_COMPILE_WARNING_AS_ERROR does not reliably stay off for FetchContent subprojects, so a warning in a bundled dependency can fail our build. On side effects: this does not relax our own strictness - iceberg's own shared/static targets keep -Werror via a per-target COMPILE_WARNING_AS_ERROR property. It only stops us from imposing -Werror on third-party subprojects we don't control, which is the intended behavior (a dependency's warnings shouldn't fail our build, and we can't fix their code). So our code stays exactly as strict as before; only the vendored dependencies are no longer forced warning-clean under our flags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
