yadavay-amzn opened a new pull request, #819: URL: https://github.com/apache/iceberg-cpp/pull/819
## What Fixes #246. `-Werror` (via a global `CMAKE_COMPILE_WARNING_AS_ERROR`) leaked into FetchContent-built dependencies, so a warning in a third-party subproject (e.g. Arrow) could fail the whole build. As noted on the issue, the global flag does not reliably isolate subprojects. ## How - Removed the global `CMAKE_COMPILE_WARNING_AS_ERROR ON`. - Set `COMPILE_WARNING_AS_ERROR ON` as a per-target property on Iceberg's own shared/static libraries, so the project stays strict. - Set `BUILD_WARNING_LEVEL PRODUCTION` for Arrow to suppress its independent `-Werror` injection. - Kept a defensive guard in `prepare_fetchcontent()` for the case where `-DCMAKE_COMPILE_WARNING_AS_ERROR=ON` is passed on the command line. ## Verified Iceberg targets still compile with `-Werror`; FetchContent subprojects do not. Build + tests green (18/18). --- This contribution was authored with assistance from Claude Opus 4.8, in line with the Iceberg guidelines for AI-assisted contributions (https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions). All changes were reviewed and tested by the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
