moomindani commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3524849840
##########
docs/docs/catalog-properties.md:
##########
@@ -33,6 +33,7 @@ Iceberg catalogs support using catalog properties to
configure catalog behaviors
| clients | 2 | client pool size
|
| cache-enabled | true | Whether to cache
catalog entries |
| cache.expiration-interval-ms | 30000 | How long catalog
entries are locally cached, in milliseconds; 0 disables caching, negative
values disable expiration |
+| cache.expire-after-write-ms | -1 | Removes a table
from the cache after the specified duration since it was created or last
updated. |
Review Comment:
This property name doesn't match the actual constant —
`CatalogProperties.CACHE_EXPIRATION_EXPIRE_AFTER_WRITE_INTERVAL_MS` is defined
as `cache.expiration.expire-after-write-interval-ms`. Could you update this row
to match (or update the constant, if the shorter name here is what you actually
want — note the existing `cache.expiration-interval-ms` sibling property uses
the shorter style too)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
