moomindani commented on PR #14440: URL: https://github.com/apache/iceberg/pull/14440#issuecomment-4885944798
Went through this again — the earlier review feedback all looks addressed: deprecation notices now include removal versions, `Ticker` moved to the last constructor argument, `createTableCache` simplified to avoid the early return, the default changed to the `-1` sentinel, validation now rejects either policy being set to `0` (with test coverage for both cases), and the Spark/Flink changes have been dropped to keep this PR scoped to core. Left one inline nit on the docs. Otherwise this looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
